Unify, deduplicate and simplify key setup #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The layer comes with pre-generated keys, thus there is no need to generate new ones. Signed-off-by: Enrico Jörns <[email protected]>
leon-anavi
approved these changes
Feb 4, 2025
It's already added by meta-rauc, thus no need to add it again. It's also not necessary to use immediate expansions for this. Signed-off-by: Enrico Jörns <[email protected]>
The certs and keys used are only redundant copies of the exact same set. To reduce duplication and simplify adding further platforms, move them all into a common directory of the base repo. Signed-off-by: Enrico Jörns <[email protected]>
Most layers use pre-generated keys anyway and while generating keys might motivate to not use known keys for production, people might misunderstand the scripts as a recommendation for creating their own PKIs. Signed-off-by: Enrico Jörns <[email protected]>
|
I've now fixed the keyring handling by removing conflicting and non-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example key handling in meta-rauc-community is a bit historically grown. Some layers use a script to generate keys on first usage, some have pre-generated keys, but the same keys are duplicated across the layers.
This PR unifies the setup by using a single pre-generated set of keys for all layers and removes the key generation which does not add sufficient benefit. Also, move the variable setting to the
layer.conf.