Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary coordinate attributes #23

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Remove unnecessary coordinate attributes #23

merged 2 commits into from
Sep 17, 2024

Conversation

sjperkins
Copy link
Member

@sjperkins sjperkins commented Sep 17, 2024 •
edited
Loading

Coordinate attributes are only necessary in AbstractVariableStore.get_variables, not in the Dataset constructor.

Thanks for contributing to xarray-ms.

We would appreciate it if you could add:

  • Test Cases covering your PR.
  • Documentation.
  • A Changelog entry in doc/source/changelog.rst.

📚 Documentation preview 📚: https://xarray-ms--23.org.readthedocs.build/en/23/

@sjperkins sjperkins merged commit 51afd54 into main Sep 17, 2024
1 check passed
@sjperkins sjperkins deleted the remove-unnecessary-coordinate-attributes branch September 17, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sjperkins