Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

katdal import improvements #325

Merged
merged 2 commits into from
Apr 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ History

X.Y.Z (YYYY-MM-DD)
------------------
* Change `dask-ms katdal import` to `dask-ms import katdal` (:pr:`325`)
* Configure dependabot (:pr:`319`)
* Add chunk specification to ``dask-ms katdal import`` (:pr:`318`)
* Add a ``dask-ms katdal import`` application for exporting SARAO archive data directly to zarr (:pr:`315`)
Expand Down
4 changes: 2 additions & 2 deletions daskms/apps/entrypoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import click

from daskms.apps.convert import convert
from daskms.apps.katdal_import import katdal
from daskms.apps.katdal_import import _import


@click.group(name="dask-ms")
Expand All @@ -16,4 +16,4 @@ def main(ctx, debug):


main.add_command(convert)
main.add_command(katdal)
main.add_command(_import)
12 changes: 6 additions & 6 deletions daskms/apps/katdal_import.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
from daskms.utils import parse_chunks_dict


@click.group()
@click.group(name="import")
@click.pass_context
def katdal(ctx):
"""subgroup for katdal commands"""
def _import(ctx):
"""subgroup for import commands"""
pass


Expand All @@ -28,7 +28,7 @@ def convert(self, value, param, ctx):
return value


@katdal.command(name="import")
@_import.command(name="katdal")
@click.pass_context
@click.argument("rdb_url", required=True)
@click.option(
Expand Down Expand Up @@ -64,9 +64,9 @@ def convert(self, value, param, ctx):
"--chunks",
callback=lambda c, p, v: parse_chunks_dict(v),
default="{time: 10}",
help="Chunking values to apply to each dimension",
help="Chunking values to apply to each dimension " "for e.g. {time: 20, chan: 64}",
)
def _import(ctx, rdb_url, output_store, no_auto, pols_to_use, applycal, chunks):
def katdal(ctx, rdb_url, output_store, no_auto, pols_to_use, applycal, chunks):
"""Export an observation in the SARAO archive to zarr formation

RDB_URL is the SARAO archive link"""
Expand Down