Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect auto-correlations via np.allclose, rather than equality #309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sjperkins
Copy link
Member

@sjperkins sjperkins commented May 27, 2024

Closes #308

  • Tests added / passed

    $ py.test -v -s africanus

    If the pre-commit tests fail, install and
    run the pre-commit hooks in your development
    virtuale environment:

    $ pip install pre-commit
    $ pre-commit install
    $ pre-commit run -a
  • Fully documented, including HISTORY.rst for all changes
    and one of the docs/*-api.rst files for new API

    To build the docs locally:

    pip install -r requirements.readthedocs.txt
    cd docs
    READTHEDOCS=True make html

@landmanbester
Copy link
Collaborator

Unfortunately this didn't solve the problem. Dropping flagged rows (the auto-corrs are flagged in this case) seems to get me around the error though

@sjperkins
Copy link
Member Author

Unfortunately this didn't solve the problem. Dropping flagged rows (the auto-corrs are flagged in this case) seems to get me around the error though

Another way this bug could manifest is if max_fov=0.0, but by default this is set to max_fov=3.0.

@landmanbester
Copy link
Collaborator

I've left it to the default in this case. Let me try to create a reproducer then we take it from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BDA averager auto_corr detection case should use a tolerance test, rather than an equality test
2 participants