Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove new_axes={'corr2': 2} in calibration utils #288

Merged
merged 2 commits into from
Sep 13, 2023
Merged

remove new_axes={'corr2': 2} in calibration utils #288

merged 2 commits into from
Sep 13, 2023

Conversation

landmanbester
Copy link
Collaborator

This was originally required because of a bug in blockwise which has now been fixed (see dask/dask#5550). Using correct_vis in DIAG_DIAG mode failed for me hence the change (not sure why the tests didn't catch that). All seems to work without the new_axes in blockwise

@sjperkins sjperkins self-assigned this Sep 13, 2023
@sjperkins sjperkins self-requested a review September 13, 2023 14:21
Copy link
Member

@sjperkins sjperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the CI successfully running through.

@sjperkins sjperkins merged commit 8620280 into ratt-ru:master Sep 13, 2023
5 checks passed
@landmanbester landmanbester deleted the fixdaskissue5550 branch September 13, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants