Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #20
This will eventually be similar to below for tests of the form:
I.e. arrays of source snippets we want to parse but are so short putting them all in their own individual files becomes annoying. This may or may not go back to being ron based as in #20 (I prefer ron's rust-like strings) but currently we can't get at spans for ron easily. Whatever format we eventually choose most of the code will end up being shared anyways.
Edit:
One thing I really don't like about this form, is that it means parsing the toml/ron/whatever twice,
once to pull out the extension for routing, and once to pull out the actual data.
I think ideally there would be a way to just partially parse this e.g. via
#![attribute(file_extension = ".foo")]
or perhaps more familiar#![cfg(file_extension = ".foo")]
Two things I really don't like about is if you change the extension in the data file, you must find some way to invalidate the old extension, which could be routed to a completely different parser, so In theory main is going to have a map for each test list so it can even notice the extension has changed.