Refactor server class to add running flag and stop() method

include/server.hpp

@@ -29,6 +29,7 @@ namespace network
     void handle_request(std::unique_ptr<request> req);
 
   private:
+    bool running = false;                    // The server is running
     boost::asio::io_context io_ctx;          // The io_context is required for all I/O
     std::vector<std::thread> threads;        // The thread pool
     boost::asio::ip::tcp::endpoint endpoint; // The endpoint for the server

src/server.cpp

@@ -4,7 +4,11 @@
 namespace network
 {
     server::server(const std::string &address, unsigned short port, std::size_t concurrency_hint) : io_ctx(concurrency_hint), endpoint(boost::asio::ip::make_address(address), port), acceptor(boost::asio::make_strand(io_ctx)) { threads.reserve(concurrency_hint); }
-    server::~server() { stop(); }
+    server::~server()
+    {
+        if (running)
+            stop();
+    }
 
     void server::start()
     {
@@ -36,6 +40,7 @@ namespace network
             return;
         }
 
+        running = true;
         do_accept();
 
         for (auto i = threads.capacity(); i > 0; --i)
@@ -51,6 +56,7 @@ namespace network
         io_ctx.stop();
         for (auto &thread : threads)
             thread.join();
+        running = false;
     }
 
     void server::do_accept() { acceptor.async_accept(io_ctx, std::bind(&server::on_accept, this, std::placeholders::_1, std::placeholders::_2)); }

tests/test_server.cpp

@@ -4,9 +4,12 @@
 int main(int argc, char const *argv[])
 {
     network::server server;
-    server.start();
 
+    std::thread t{[&server]
+                  { server.start(); }};
     std::this_thread::sleep_for(std::chrono::seconds(10));
+    server.stop();
+    t.join();
 
     return 0;
 }