Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Add support for default values in Symfony route configuration
With the current version of Ratchet, it is possible to make wildcard routes using route placeholders as mentioned in Symfony routing docs
I have written more about this here: How to implement wildcard routes in Ratchet WebSocket server
However, there is a catch.
We can use routing placeholders but cannot make any of them optional, by passing a default value for them.
What this merge will add:
For a setup like this:
$server->route('/{something}/{anotherThing}', new MyApp(), array('*'))
After the merge, we can make
anotherThing
optional by modifying the route config to this:$server->route('/{something}/{anotherThing}', new MyApp(), array('*'),null,array('anotherThing'=>1))