Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dynamic Properties warnings for PHP >= 8.2 #1060

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JohnRDOrazio
Copy link

fix dynamic properties warnings for PHP >= 8.2

fix dynamic properties warnings for PHP >= 8.2
@JohnRDOrazio
Copy link
Author

this is a simple and straightforward way to fix issue #1003 , without having to explicitly declare all of the properties for every class.

Copy link

@VidarSandvik VidarSandvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it fixed some issues but basically the entire ratchet needs to be updated to support above PHP 8.2

@JohnRDOrazio
Copy link
Author

JohnRDOrazio commented Jun 26, 2024

Need connection class change

I assume you mean that we need the same fix on React\Socket\Connection. This however is in a different repository (https://github.com/reactphp/socket/). Perhaps it would be fixed by PR #1065?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants