-
Notifications
You must be signed in to change notification settings - Fork 33
Added optional CSS enhancements for better rendering #20
base: master
Are you sure you want to change the base?
Conversation
/* optional enhancements for better rendering */ | ||
text-rendering: auto; | ||
-webkit-font-smoothing: antialiased; | ||
-moz-osx-font-smoothing: grayscale; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not future and mobile friendly.
It screw up rendering on HiDPI screens (most smart phones these days + Retina Display on Mac + potentially high end monitors and windows laptops)
I know it might still work for Desktops in Iran but I feel they shouldn't be recommended in Readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I'm aware of that and that's why I wrote "Optional".
Since "Font Awesome" has also included these lines from the very first version and apparently they haven't had any problem with it, I thought it could be a nice option to include it here and let the user decide. What do yo think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works for icon fonts most of the time since they don't have tiny stokes. The antialiased
causes the text to appear slimmer and blurry on HiDPI screens (unlike the old CRT and low density LCD monitors) and it's really bad for fonts with tiny and cursive stokes like Arabic alphabet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, But I had so many issues with Chrome/Webkit font rendering on Win7 and -webkit-font-smoothing actually helped. anyways, it's just a suggestion...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit selfish of mine to ask for removal of this. I was looking at some of the issues on Vazir font with some screenshots which are horrible in resolution.
Normal people don't have high end devices like us! I keep forgetting this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well said, I'm okay with any decisions you guys make about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
من فکر می کردم با هینتینگی که انجام شده دیگه کسی مشکلی نداشته باشه. یعنی هنوز مشکل پابرجاست؟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
من خودم مشکلی نداشتم تا الان
These lines may improve readability in some OS/Browsers