Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show sizes less than 1GB in more detail #737

Open
wants to merge 1 commit into
base: qml
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
249 changes: 128 additions & 121 deletions src/i18n/rpi-imager_ca.ts

Large diffs are not rendered by default.

245 changes: 130 additions & 115 deletions src/i18n/rpi-imager_de.ts

Large diffs are not rendered by default.

263 changes: 121 additions & 142 deletions src/i18n/rpi-imager_en.ts

Large diffs are not rendered by default.

241 changes: 128 additions & 113 deletions src/i18n/rpi-imager_es.ts

Large diffs are not rendered by default.

247 changes: 129 additions & 118 deletions src/i18n/rpi-imager_fr.ts

Large diffs are not rendered by default.

245 changes: 130 additions & 115 deletions src/i18n/rpi-imager_it.ts

Large diffs are not rendered by default.

247 changes: 129 additions & 118 deletions src/i18n/rpi-imager_ja.ts

Large diffs are not rendered by default.

245 changes: 130 additions & 115 deletions src/i18n/rpi-imager_ko.ts

Large diffs are not rendered by default.

245 changes: 130 additions & 115 deletions src/i18n/rpi-imager_nl.ts

Large diffs are not rendered by default.

247 changes: 129 additions & 118 deletions src/i18n/rpi-imager_ru.ts

Large diffs are not rendered by default.

249 changes: 128 additions & 121 deletions src/i18n/rpi-imager_sk.ts

Large diffs are not rendered by default.

251 changes: 127 additions & 124 deletions src/i18n/rpi-imager_sl.ts

Large diffs are not rendered by default.

255 changes: 125 additions & 130 deletions src/i18n/rpi-imager_tr.ts

Large diffs are not rendered by default.

245 changes: 130 additions & 115 deletions src/i18n/rpi-imager_uk.ts

Large diffs are not rendered by default.

245 changes: 130 additions & 115 deletions src/i18n/rpi-imager_zh-TW.ts

Large diffs are not rendered by default.

251 changes: 127 additions & 124 deletions src/i18n/rpi-imager_zh.ts

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion src/main.qml
Original file line number Diff line number Diff line change
Expand Up @@ -894,7 +894,9 @@ ApplicationWindow {
? qsTr("Cached on your computer")
: url.startsWith("file://")
? qsTr("Local file")
: qsTr("Online - %1 GB download").arg((image_download_size/1073741824).toFixed(1))
: image_download_size >= 1073741824
? qsTr("Online - %1 GB download").arg((image_download_size/1073741824).toFixed(1))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking on this further - given we're reusing GB/MB across languages, perhaps we could make GB/MB and untranslated parameter to this string, and just prune it from the translations?

: qsTr("Online - %1 MB download").arg((image_download_size/1048576).toFixed(1))
}

ToolTip {
Expand Down