Bug 1668 v2 - Provide method to prevent init of SYS_CLK, when left on during 'lightsleep' #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing 'lightsleep' During 'lightsleep' user may want to keep some clocks running (for example PIOs), but at present microPython calls 'clock-init()' causing the SYS_CLK to be reinitialised. This patch allows microPython to provide the previously used 'sleep_en0 & sleep_en1' signifying which clocks stayed on. As most are dependant of SYS_CLK it can be inferred that this does NOT need to (/should NOT) be re-initilised.
lurch
reviewed
Mar 18, 2024
lurch
reviewed
Mar 18, 2024
|
Yes, should be a logical "&&". I'll update PR and add some documentation. Thanks. |
lurch
reviewed
Mar 20, 2024
lurch
reviewed
Mar 20, 2024
lurch
reviewed
Mar 20, 2024
lurch
reviewed
Mar 21, 2024
|
I removed the tabs. Do you want the whole series resubmitted (_v3?) as a single patch/pull request? |
|
That's not my decision to make, so leave it as-is for now unless asked otherwise 🙂 |
2 tasks
|
fixes #1668 |
lurch
reviewed
May 20, 2024
Comment on lines
217
to
226
| /// \tag::configure_clk_sys[] | ||
| // CLK SYS = PLL SYS (usually) 125MHz / 1 = 125MHz | ||
| clock_configure(clk_sys, | ||
| CLOCKS_CLK_SYS_CTRL_SRC_VALUE_CLKSRC_CLK_SYS_AUX, | ||
| CLOCKS_CLK_SYS_CTRL_AUXSRC_VALUE_CLKSRC_PLL_SYS, | ||
| SYS_CLK_KHZ * KHZ, | ||
| SYS_CLK_KHZ * KHZ); | ||
| if (init_sys_clock) { | ||
| clock_configure(clk_sys, | ||
| CLOCKS_CLK_SYS_CTRL_SRC_VALUE_CLKSRC_CLK_SYS_AUX, | ||
| CLOCKS_CLK_SYS_CTRL_AUXSRC_VALUE_CLKSRC_PLL_SYS, | ||
| SYS_CLK_KHZ * KHZ, | ||
| SYS_CLK_KHZ * KHZ); | ||
| } | ||
| /// \end::configure_clk_sys[] |
There was a problem hiding this comment.
This "tag" is used to auto-include this code snippet into page 191 of https://datasheets.raspberrypi.com/rp2040/rp2040-datasheet.pdf
So in order not to clutter that example, it might make sense to move your new if check to outside of the tag? i.e.
if (init_sys_clock) {
/// \tag::configure_clk_sys[]
// CLK SYS = PLL SYS (usually) 125MHz / 1 = 125MHz
clock_configure(clk_sys,
CLOCKS_CLK_SYS_CTRL_SRC_VALUE_CLKSRC_CLK_SYS_AUX,
CLOCKS_CLK_SYS_CTRL_AUXSRC_VALUE_CLKSRC_PLL_SYS,
SYS_CLK_KHZ * KHZ,
SYS_CLK_KHZ * KHZ);
/// \end::configure_clk_sys[]
}
|
If this patch was extended to also check and selectively init PLL_USB then it would also meet the use case in #1746. Looks like a good approach to reuse the sleep bits this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During 'lightsleep' user may want to keep some clocks running (for example PIOs), but at present microPython calls 'clock-init()' causing the SYS_CLK to be reinitialized.
This patch allows microPython to provide the previously used 'sleep_en0 & sleep_en1' signifying which clocks stayed on. As most are dependant of SYS_CLK it can be inferred that this does NOT need to (/should NOT) be re-initialized.