fix: PICO_SCANVIDEO_PIXEL_... macros assume 5-bit color #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed a few extra gpio pins, so reduced the color depth by adding some definitions to
CMakeLists
:This works but the PICO_SCANVIDEO_PIXEL_FROM_RGB8 macro is broken since it assumes 5 bit values so colors are messed up.
This PR fixes it and some related macros.
btw, loving this library, thanks for sharing!