Add 640x400 @ 70Hz mode #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'd be great if someone could document how the timing parameters are set up.
I added the 640x400 mode per http://www.tinyvga.com/vga-timing/640x400@70Hz since that aspect ratio is useful for me.
It seems to work but I'm uncertain about how to choose the different parameters since the 640x480 mode seems slightly different from the spec at http://www.tinyvga.com/vga-timing/640x480@60Hz and elsewhere.
I'm also curious why the PICO_SCANVIDEO_48MHZ modes are all ifdef'd out by default. I tried to add them back with
add_definitions( -DPICO_SCANVIDEO_48MHZ=1 )but they didn't seem to work directly even tho the clock seems slower than default 640x480 mode.