ASoC: dwc: Fix full-duplex mode #5757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2023
popcornmix
reviewed
Nov 28, 2023
| @@ -210,10 +212,6 @@ static void dw_i2s_config(struct dw_i2s_dev *dev, int stream) | |||
| dmacr |= (DMACR_DMAEN_RXCH0 << ch_reg); | |||
There was a problem hiding this comment.
It looks to me with the old code, unused channels would be cleared (by the dmacr=0 initialisation and then not setting the bit). Does this still happen with new code? (e.g. if this is called once with config->chan_nr=4 and then with config->chan_nr=2.
(Note: I'm not familiar with how this code is called, so ignore if you are happy with new behaviour).
There was a problem hiding this comment.
That's annoyingly correct. I've added clearing of the relevant group of channel enable flags before setting the appropriate number.
Configuration of the DMA register was carelessly zeroing bits that may used by a stream in the other direction. Preserve them instead. See: raspberrypi#5741 Signed-off-by: Phil Elwell <[email protected]>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Nov 29, 2023
kernel: arch: arm: configs: add HID_NINTENDO to rpi defconfigs See: raspberrypi/linux#5754 kernel: ASoC: dwc: Fix full-duplex mode See: raspberrypi/linux#5757
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Nov 29, 2023
kernel: arch: arm: configs: add HID_NINTENDO to rpi defconfigs See: raspberrypi/linux#5754 kernel: ASoC: dwc: Fix full-duplex mode See: raspberrypi/linux#5757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration of the DMA register was carelessly zeroing bits that may used by a stream in the other direction. Preserve them instead.
See: #5741