spi: dw-dma: Get the last DMA scoop out of the FIFO #5699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a DMA FIFO threshold greater than 1 (encoded as 0), it is possible for data in the FIFO to be inaccessible, causing the transfer to fail after a timeout. If the transfer includes a transmission, reduce the RX threshold when the TX completes, otherwise use 1 for the whole transfer (inefficient, but not catastrophic at SPI data rates). See: raspberrypi#5696 Signed-off-by: Phil Elwell <[email protected]>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Nov 21, 2023
kernel: KMS stale dlist alloc changes See: raspberrypi/linux#5684 kernel: drm/vc4: crtc: Support odd horizontal timings on BCM2712 See: raspberrypi/linux#5679 kernel: spi: dw-dma: Get the last DMA scoop out of the FIFO See: raspberrypi/linux#5699 kernel: defconfigs: Drop FB_UDL from all Pi defconfigs See: raspberrypi/linux#5702 kernel: RP1 GPIO header SDIO support See: raspberrypi/linux#5704 kernel: ASoC: bcm: audioinjector_octo: Add soundcard owner See: raspberrypi/linux#5705 kernel: drivers: media: imx708: Tweak broken line correction parameter See: raspberrypi/linux#5701
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Nov 21, 2023
kernel: KMS stale dlist alloc changes See: raspberrypi/linux#5684 kernel: drm/vc4: crtc: Support odd horizontal timings on BCM2712 See: raspberrypi/linux#5679 kernel: spi: dw-dma: Get the last DMA scoop out of the FIFO See: raspberrypi/linux#5699 kernel: defconfigs: Drop FB_UDL from all Pi defconfigs See: raspberrypi/linux#5702 kernel: RP1 GPIO header SDIO support See: raspberrypi/linux#5704 kernel: ASoC: bcm: audioinjector_octo: Add soundcard owner See: raspberrypi/linux#5705 kernel: drivers: media: imx708: Tweak broken line correction parameter See: raspberrypi/linux#5701
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a DMA FIFO threshold greater than 1 (encoded as 0), it is possible for data in the FIFO to be inaccessible, causing the transfer to fail after a timeout. If the transfer includes a transmission, reduce the RX threshold when the TX completes, otherwise use 1 for the whole transfer (inefficient, but not catastrophic at SPI data rates).
See: #5696