Remove MergeConfig() and SetOutputAXI() #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MergeConfig() was uncalled, probably broken on BE and potentially confusing on FE now that Prepare() can modify its output config. FrontEnd::SetOutputAXI() was uncalled, and changing these settings from their defaults ought to be deprecated. (Narrowly avoided removing SetHog(), as test code still calls it.)
naushir
reviewed
Dec 1, 2023
|
Looks good, just a minor question re the AXI output removal. |
|
Actually I think we can remove HOG as well now (I will add a further commit and squash it with the second one). |
|
Oh, too late to remove HOG. Worth doing as a separate commit? |
Sure why not! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also an unrelated commit that I think fixes a bug in backend_debug?