frontend: Fix stats config params for stats decimation. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix for #10. |
|
@njhollinghurst can you check my logic looks correct here? |
|
Yes I think so, if you put back the force-to-even (and maybe do some check to ensure nonzero?) BTW I vaguely feel Prepare/Finalize ought to be more like this in general, to abstract the user configuration at a higher level and be more opaque about the details of the "binary" configuration. But that's outside the scope here. |
Decimate the stats config params in the buffer provided by FrontEnd::Prepare(). With this change, we use the undecimated coordinate space for all the config structures within the Frontend class. Signed-off-by: Naushir Patuck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decimate the stats config params in the buffer provided by FrontEnd::Prepare(). With this change, we use the undecimated coordinate space for all the config structures within the Frontend class.