Fix/cleanup pre commit findings #100
Conversation
Signed-off-by: Nick M <[email protected]>
Signed-off-by: Nick M <[email protected]>
Signed-off-by: Nick M <[email protected]>
Terraform Format and Style 🖌
|
| unsafeSkipCAVerification: false | ||
| caCertHashes: | ||
| - sha256:{{ cluster_ca_sha256 }} | ||
| - sha256:{{ cluster_ca_sha256 }} |
There was a problem hiding this comment.
| - sha256:{{ cluster_ca_sha256 }} | |
| - sha256: {{ cluster_ca_sha256 }} |
| kind: InitConfiguration | ||
| bootstrapTokens: | ||
| - token: {{ kubeadm_join_token }} | ||
| ttl: 1h |
There was a problem hiding this comment.
| ttl: 1h | |
| ttl: 24h |
| groups: | ||
| - system:bootstrappers:kubeadm:default-node-token | ||
| usages: | ||
| - signing | ||
| - authentication |
There was a problem hiding this comment.
Are these still requried for 1.20.x?
| bindPort: {{ cluster_apiserver_bind_port }} | ||
| certificateKey: {{ kubeadm_certificate_key }} | ||
| nodeRegistration: | ||
| {% if inventory_hostname in groups['masters'] and inventory_hostname not in groups['workers'] %} |
There was a problem hiding this comment.
How do you feel about adding labels on worker nodes with node-role.kubernetes.io/worker ?
|
The SSH key being dropped is a known shared private key. This allows you to setup a group of vms with terraforms then provide ansible with a identity file. This allows us not having to share our personal SSH public keys on the readily available terraform. Shown here: We can drop it if we want but it makes provisioning quick and easy. It's not unsafe to persist this in the repo as this keypair is only designed for building up local vms and is no longer used after they're torn down |
|
We'll need to update this with the new control-plane/node PR to remove |
Description
Cleans up some pre-commit findings.. @anthr76 - have a look since this removes private keys.