fix: some fixes to errors raised #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emits nicer ValueErrors in a couple of instances, instead of mere assertions. Also adds some .github YAML configurations for upcoming changes to CD.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
=======================================
Coverage 98.60% 98.61%
=======================================
Files 15 15
Lines 1076 1081 +5
=======================================
+ Hits 1061 1066 +5
Misses 15 15 ☔ View full report in Codecov by Sentry. |
mkolopanis
reviewed
Jan 18, 2024
mkolopanis
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emits nicer
ValueErrors in a couple of instances, instead of mere assertions. Also adds some.githubYAML configurations for upcoming changes to CD. These files are required to be in main before making the changes I want to make later (which will automatically create release drafts when PRs are merged).The CD files are similar to what is now done in eg. uvtools
Fixes #69
Fixes #77
Fixes #68