Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci fix #1066

Merged
merged 7 commits into from
Sep 22, 2023
Merged

ci fix #1066

merged 7 commits into from
Sep 22, 2023

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Sep 21, 2023

No description provided.

@jmahlik
Copy link
Contributor

jmahlik commented Sep 21, 2023

I wonder if making a fresh new conda environment might be an alternative to updating the base?

Or pip installing the development requirements in base from a testing extra? Like python -m pip install .[testing]? Then you might not have to mess with conda updates at all.

@rasbt
Copy link
Owner Author

rasbt commented Sep 21, 2023

Yeah, I actually intermittently tried pip but then it had some issues with Cython. I wanted to just get it to work again like it used to -- it worked a few months ago. It's really frustrating to not have direct access to the machine and to try it one commit at a time 😅

@jmahlik
Copy link
Contributor

jmahlik commented Sep 21, 2023

Willing to take a look/help out. I do ci stuff a lot at work.

@rasbt
Copy link
Owner Author

rasbt commented Sep 21, 2023

Thanks, I think the problem is that we are using old package versions. And there seems to be some incompatibility with the latest Ubuntu version and and old glib version that is required here.

In an ideal world, this could be fixed by updating the unit tests to use the latest packages for pandas etc. But this would require other work in the frequent pattern submodules, which I am saving for a rainy day in the future.

It's tricky. Let's see if this older Ubuntu version works first and go from there 😅

Copy link
Owner Author

@rasbt rasbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump version

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (68d4d39) 77.26% compared to head (a584bb2) 77.26%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1066   +/-   ##
=======================================
  Coverage   77.26%   77.26%           
=======================================
  Files         200      200           
  Lines       11297    11297           
  Branches     1483     1513   +30     
=======================================
  Hits         8729     8729           
  Misses       2350     2350           
  Partials      218      218           
Files Changed Coverage Δ
mlxtend/_base/_base_model.py 50.00% <ø> (ø)
mlxtend/_base/_classifier.py 94.11% <ø> (ø)
mlxtend/_base/_cluster.py 89.47% <ø> (ø)
mlxtend/_base/_iterative_model.py 91.07% <ø> (ø)
mlxtend/_base/_multiclass.py 100.00% <ø> (ø)
mlxtend/_base/_multilayer.py 100.00% <ø> (ø)
mlxtend/_base/_regressor.py 91.30% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rasbt
Copy link
Owner Author

rasbt commented Sep 22, 2023

It seemed to be a Cython issue that was fixed 🎉 by bumping the sklearn version @jmahlik

@rasbt rasbt merged commit fe92dd0 into master Sep 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants