test: fix flaky download assertion

Signed-off-by: rare-magma <[email protected]>
rare-magma · Jul 3, 2024 · 43f63a2 · 43f63a2
1 parent 55a1625
commit 43f63a2
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/e2e/settingsHappyPath.test.ts b/e2e/settingsHappyPath.test.ts
@@ -59,9 +59,17 @@ test("should complete the settings happy path", async ({ page, isMobile }) => {
   await page.getByLabel("import or export budget").click();
   await expect(page.getByText("json")).toBeVisible();
 
-  const jsonDownloadPromise = page.waitForEvent("download");
-  await page.getByLabel("export budget as json").click();
-  const jsonDownload = await jsonDownloadPromise;
+  const [jsonDownload] = await Promise.all([
+    page.waitForEvent("download"),
+    page.getByLabel("export budget as json").click(),
+  ]);
+
+  let downloadError = await jsonDownload.failure();
+  if (downloadError !== null) {
+    console.log("Error on download:", downloadError);
+    throw new Error(downloadError);
+  }
+
   expect(jsonDownload.suggestedFilename()).toMatch(/.json/);
   expect(
     (await fs.promises.stat(await jsonDownload.path())).size,