Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rustls for tls implementation #152

Closed
wants to merge 1 commit into from

Conversation

sunng87
Copy link
Contributor

@sunng87 sunng87 commented Apr 8, 2022

This patch switches tls backend to rustls from openssl. This makes cross-compiling to arm and other architecture easier by not requiring openssl headers. Also the rustls implementation is more future promising in term of security and safety.

I will be using this branch in my own setup. If the change makes sense, I will finish some minor TODO items to improve the code quality.

Thank you for this excellent tool!

@rapiz1
Copy link
Owner

rapiz1 commented Apr 8, 2022 via email

@rapiz1
Copy link
Owner

rapiz1 commented Jun 25, 2022

I'm thinking about adding a compile flag ( features, in cargo's terms) to compile with rustls, instead of replacing openssl. We can use this as meditation since rustls doesn't fit all our requirements (see above). Are you still interested in this work?

@sunng87
Copy link
Contributor Author

sunng87 commented Jun 26, 2022

@rapiz1 I'm no longer working on this. So feel free to pick it up for further development. Using feature flag for rustls makes a lot of sense. Thank you!

@rapiz1 rapiz1 force-pushed the main branch 8 times, most recently from 78f1157 to 97541af Compare October 1, 2023 09:13
@hillct hillct mentioned this pull request Nov 12, 2023
@sunmy2019
Copy link
Contributor

Interesting. I am struggling with rustls now. Glad to find this PR.

@sunmy2019
Copy link
Contributor

rustls 0.22 introducing some breaking changes that invalidates this code.

I am discovering how to fix. May take longer than I expected.

@rapiz1
Copy link
Owner

rapiz1 commented Feb 18, 2024

merged via #330

@rapiz1 rapiz1 closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants