Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new rapids-logger library #364

Open
wants to merge 8 commits into
base: branch-0.43
Choose a base branch
from

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 3, 2025

ucxx only needs minor changes here to adapt for the upstream rmm changes.

Contributes to rapidsai/build-planning#104.

@vyasr vyasr added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 3, 2025
@vyasr vyasr self-assigned this Feb 3, 2025
Copy link

copy-pr-bot bot commented Feb 3, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@vyasr
Copy link
Contributor Author

vyasr commented Feb 3, 2025

/ok to test

@vyasr vyasr force-pushed the feat/rapids_logger_library branch from 4d461a9 to 2ebc5e7 Compare February 3, 2025 17:42
@vyasr
Copy link
Contributor Author

vyasr commented Feb 3, 2025

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Feb 3, 2025

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Feb 3, 2025

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Feb 3, 2025

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Feb 3, 2025

/ok to test

@vyasr vyasr marked this pull request as ready for review February 4, 2025 21:40
@vyasr vyasr requested review from a team as code owners February 4, 2025 21:40
@vyasr vyasr requested a review from AyodeAwe February 4, 2025 21:40
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just want to confirm import rmm won't create a CUDA context or any other resources when RMM is installed (but potentially remain unused dependending on the application needs).

python/libucxx/libucxx/load.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants