Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for RMM internal macros. #1847

Open
wants to merge 1 commit into
base: branch-25.04
Choose a base branch
from
Open

Add tests for RMM internal macros. #1847

wants to merge 1 commit into from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 4, 2025 •
edited
Loading

Description

This PR adds tests for internal macros. Closes #1848.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested review from a team as code owners March 4, 2025 16:03
@bdice bdice requested review from harrism and miscco March 4, 2025 16:03
@github-actions github-actions bot added CMake cpp Pertains to C++ code labels Mar 4, 2025
vyasr
vyasr approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/rmm-cmake-codeowners

@miscco miscco Awaiting requested review from miscco miscco is a code owner automatically assigned from rapidsai/rmm-cpp-codeowners

Assignees
No one assigned
Labels
CMake cpp Pertains to C++ code
Projects
RMM Project Board
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Test internal macros and discourage external usage
2 participants
@bdice @vyasr