Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignored cuda-python deprecation warning. #1768

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Remove ignored cuda-python deprecation warning. #1768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43b32eb
Remove cuda-python deprecation warning.
bdice Dec 16, 2024
8afcc13
Use cuda.bindings layout in tests.
bdice Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion python/rmm/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ max_allowed_size_compressed = '75M'
# treat warnings as errors
filterwarnings = [
"error",
"ignore:.*cuda..* module is deprecated.*:DeprecationWarning"
]

[tool.ruff]
Expand Down
24 changes: 12 additions & 12 deletions python/rmm/rmm/tests/test_rmm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
import warnings
from itertools import product

import cuda.cudart as cudart
import numpy as np
import pytest
from cuda.bindings import runtime
from numba import cuda

import rmm
Expand All @@ -34,7 +34,7 @@
cuda.set_memory_manager(RMMNumbaManager)

_SYSTEM_MEMORY_SUPPORTED = rmm._cuda.gpu.getDeviceAttribute(
cudart.cudaDeviceAttr.cudaDevAttrPageableMemoryAccess,
runtime.cudaDeviceAttr.cudaDevAttrPageableMemoryAccess,
rmm._cuda.gpu.getDevice(),
)

Expand Down Expand Up @@ -319,13 +319,13 @@ def test_rmm_device_buffer_pickle_roundtrip(hb):


def assert_prefetched(buffer, device_id):
err, dev = cudart.cudaMemRangeGetAttribute(
err, dev = runtime.cudaMemRangeGetAttribute(
4,
cudart.cudaMemRangeAttribute.cudaMemRangeAttributeLastPrefetchLocation,
runtime.cudaMemRangeAttribute.cudaMemRangeAttributeLastPrefetchLocation,
buffer.ptr,
buffer.size,
)
assert err == cudart.cudaError_t.cudaSuccess
assert err == runtime.cudaError_t.cudaSuccess
assert dev == device_id


Expand All @@ -336,11 +336,11 @@ def test_rmm_device_buffer_prefetch(pool, managed):
rmm.reinitialize(pool_allocator=pool, managed_memory=managed)
db = rmm.DeviceBuffer.to_device(np.zeros(256, dtype="u1"))
if managed:
assert_prefetched(db, cudart.cudaInvalidDeviceId)
assert_prefetched(db, runtime.cudaInvalidDeviceId)
db.prefetch() # just test that it doesn't throw
if managed:
err, device = cudart.cudaGetDevice()
assert err == cudart.cudaError_t.cudaSuccess
err, device = runtime.cudaGetDevice()
assert err == runtime.cudaError_t.cudaSuccess
assert_prefetched(db, device)


Expand Down Expand Up @@ -830,15 +830,15 @@ def test_prefetch_resource_adaptor(managed):
# This allocation should be prefetched
db = rmm.DeviceBuffer.to_device(np.zeros(256, dtype="u1"))

err, device = cudart.cudaGetDevice()
assert err == cudart.cudaError_t.cudaSuccess
err, device = runtime.cudaGetDevice()
assert err == runtime.cudaError_t.cudaSuccess

if managed:
assert_prefetched(db, device)
db.prefetch() # just test that it doesn't throw
if managed:
err, device = cudart.cudaGetDevice()
assert err == cudart.cudaError_t.cudaSuccess
err, device = runtime.cudaGetDevice()
assert err == runtime.cudaError_t.cudaSuccess
assert_prefetched(db, device)


Expand Down
Loading