Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ruff, remove isort and black. #1759

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Use ruff, remove isort and black. #1759

merged 4 commits into from
Dec 11, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 11, 2024

Description

Closes #1758.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 11, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Python Related to RMM Python API label Dec 11, 2024
@bdice bdice self-assigned this Dec 11, 2024
@bdice bdice added feature request New feature or request non-breaking Non-breaking change labels Dec 11, 2024
@bdice bdice marked this pull request as ready for review December 11, 2024 00:12
@bdice bdice requested review from a team as code owners December 11, 2024 00:12
@bdice bdice requested a review from AyodeAwe December 11, 2024 00:12
jameslamb
jameslamb approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally support this, thanks! And thanks for adding the comments on each code in pyproject.toml.

@jameslamb jameslamb removed the request for review from AyodeAwe December 11, 2024 18:15
@bdice
Copy link
Contributor Author

bdice commented Dec 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit 3cad8fe into rapidsai:branch-25.02 Dec 11, 2024
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt711 Matt711 Matt711 approved these changes

@jameslamb jameslamb jameslamb approved these changes

Assignees

@bdice bdice

Labels
feature request New feature or request non-breaking Non-breaking change Python Related to RMM Python API
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Use ruff instead of black / isort for linting
3 participants
@bdice @jameslamb @Matt711