Skip to content

Commit

Permalink
remove setup.cfg, use pyproject.toml (#736)
Browse files Browse the repository at this point in the history
This repo doesn't have a Python package or use `setuptools`, but it has a `setup.cfg`... to hold configuration for tools like `codespell`.

This proposes removing that and using a `pyproject.toml` to store that configuration, matching the conventions used across most of the rest of RAPIDS.

It also updates pre-commit configurations to use the latest version of `rapids-dependency-file-generator` (v1.17.0).

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #736
jameslamb authored Dec 24, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent faef975 commit 840accd
Showing 4 changed files with 17 additions and 15 deletions.
8 changes: 5 additions & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.4.0
rev: v5.0.0
hooks:
- id: trailing-whitespace
exclude: |
@@ -24,11 +24,13 @@ repos:
types_or: [c, c++, cuda]
args: ["-fallback-style=none", "-style=file", "-i"]
- repo: https://github.com/codespell-project/codespell
rev: v2.2.2
rev: v2.3.0
hooks:
- id: codespell
additional_dependencies: [tomli]
args: ["--toml", "pyproject.toml"]
- repo: https://github.com/rapidsai/dependency-file-generator
rev: v1.8.0
rev: v1.17.0
hooks:
- id: rapids-dependency-file-generator
args: ["--clean"]
10 changes: 10 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Copyright (c) 2024, NVIDIA CORPORATION.

[tool.codespell]
# note: pre-commit passes explicit lists of files here, which this skip file list doesn't override -
# this is only to allow you to run codespell interactively
skip = "./.git"
# ignore short words, and typename parameters
ignore-regex = "\\b(.{1,4}|[A-Z]\\w*T)\\b"
builtin = "clear"
quiet-level = 3
4 changes: 2 additions & 2 deletions rapids-cmake/test/gpu_requirements.cmake
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#=============================================================================
# Copyright (c) 2022-2023, NVIDIA CORPORATION.
# Copyright (c) 2022-2024, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
@@ -77,7 +77,7 @@ function(rapids_test_gpu_requirements test_name)
set(percent ${_RAPIDS_TEST_PERCENT})
endif()

# verify that gpu and percent are withing the allowed bounds
# verify that gpu and percent are within the allowed bounds
if(NOT gpus GREATER_EQUAL 0)
message(FATAL_ERROR "rapids_test_gpu_requirements requires a numeric GPUS value [0-N].")
endif()
10 changes: 0 additions & 10 deletions setup.cfg

This file was deleted.

0 comments on commit 840accd

Please sign in to comment.