Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update automatic "Python" labeler #20

Closed
wants to merge 2 commits into from
Closed

Update automatic "Python" labeler #20

wants to merge 2 commits into from

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Nov 13, 2024

Triggered by changes to nx_cugraph/ and _nx_cugraph.

Is this label still useful to us or to ops?

@eriknw
Update automatic "Python" labeler
ab9547f 
Triggered by changes to `nx_cugraph/` and `_nx_cugraph`.

Is this label still useful to us or to ops?
@eriknw eriknw requested a review from a team as a code owner November 13, 2024 16:55
@eriknw eriknw requested a review from jameslamb November 13, 2024 16:55
@eriknw eriknw added non-breaking Introduces a non-breaking change ci bug Something isn't working improvement Improves an existing functionality and removed improvement Improves an existing functionality labels Nov 13, 2024
jameslamb
jameslamb approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving you a ci-codeowners approval. Up to you if you want to use this. My opinion... now that this is in its own repo, and since it doesn't have a C++ component, I don't think a separate python label is that valuable.

@eriknw
Copy link
Contributor Author

eriknw commented Nov 14, 2024

Thanks. Yeah, I don't have an opinion one way or another. I suppose it would be nicer to have one less label to choose from when assigning labels manually.

eriknw added a commit to eriknw/nx-cugraph that referenced this pull request Nov 14, 2024
@eriknw
Remove automatic "Python" labeler
f1191fd 
An alternative to rapidsai#20
@eriknw eriknw mentioned this pull request Nov 14, 2024
Merged
@eriknw
Copy link
Contributor Author

eriknw commented Nov 14, 2024

Alternative that removes it (for when we decide what to do): #23

@github-actions github-actions bot removed the ci label Nov 15, 2024
@eriknw
Copy link
Contributor Author

eriknw commented Nov 15, 2024

Closing in favor of #23 (for now)

@eriknw eriknw closed this Nov 15, 2024
rapids-bot bot pushed a commit that referenced this pull request Nov 18, 2024
@eriknw
Remove automatic "Python" labeler (#23)
3eb6afc 
An alternative to #20

Authors:
  - Erik Welch (https://github.com/eriknw)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eriknw @jameslamb