-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .pre-commit-config.yaml
and Implement Suggestions
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-rliu
added
breaking
Introduces a breaking change
improvement
Improves an existing functionality
and removed
benchmarks
labels
Oct 30, 2024
jameslamb
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions for your consideration.
Other notes:
- please add CI here in this PR just running
pre-commit
(similar to introduce minimal CI for PRs cugraph-gnn#56). That'd make us more confident in these changes - There are many references in this diff to "cugraph" which really should be "nx-cugraph". I suspect there are more that are in the repo but didn't show up in the diff... those should be fixed (can be a follow-up PR).
jameslamb
reviewed
Oct 30, 2024
jameslamb
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
Notes for Reviewers
This PR was mainly designed to consolidate (previously)
lint.yaml
intopre-commit-hooks.yaml
. I tried to preserve all the hooks fromlint.yaml
and remove hooks/directories/etc that are no longer needed. Feel free to let me know if some of these checks are redundant or seem incorrect.Proposed Changes
.flake8
configlint.yaml
file into.pre-commit-config.yaml
dependencies.yaml
after getting rid of the oldpython/nx-cugraph
dirpyproject.toml
using pre-commit