-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React/regl client app for displaying point-in-polygon point clouds. #436
Open
thomcom
wants to merge
158
commits into
rapidsai:main
Choose a base branch
from
thomcom:feature/react-webgl-client-app
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of blindly gathering.
trxcllnt
reviewed
Oct 6, 2022
@@ -0,0 +1,4903 @@ | |||
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should remove this file before merging
trxcllnt
reviewed
Oct 6, 2022
trxcllnt
reviewed
Oct 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should remove the file at modules/demo/particles/src/logo.svg too.
… Working on translation now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This app will display 2d point clouds that are returned from an
api-server
I/O routine.The app will display a background image that scales and translates with the GL view, displaying points that are contained within the viewport and culling the rest.
Part of the demo will provide an option to disable view translation but retain the viewport culling, so that points are culled from the center of the display, demonstrating the culling.
Depends on #427
Steps remaining:
api-server
api-server
endpoint to feed data via arrowI am going to split this PR up into one for the
api-server
updates and one for theparticles
app. There are also updates tosigma.js
that need to be pushed to their own PR.