Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pins on geospatial libraries, RAPIDS nightlies #722

Merged
merged 8 commits into from
Sep 24, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Sep 19, 2024

Contributes to rapidsai/build-planning#56

With rapidsai/cuspatial#1441, it should be possible to revert some of the workarounds introduced in #719.

Notes for Reviewers

How to test this

if this is working, we should see the following in the conda solves:

  • fmt >=11.0.2
  • spdlog >=1.14.1

We won't see numpy >=2 yet, because cugraph doesn't support it yet (rapidsai/cugraph#4615).

@jameslamb jameslamb changed the title WIP: remove pins on geospatial libraries, specific RAPIDS nightlies WIP: remove pins on geospatial libraries, most RAPIDS nightlies Sep 19, 2024
@jameslamb jameslamb changed the title WIP: remove pins on geospatial libraries, most RAPIDS nightlies WIP: remove pins on geospatial libraries, RAPIDS nightlies Sep 19, 2024
@jameslamb
Copy link
Member Author

🎉 looks like it's possible to solve an environment with all of RAPIDS + the newer versions of fmt and spdlog 🎉

...
cucim:                            24.10.00a18-cuda11_py312_240919_g8461465_18      rapidsai-nightly
...
cudf:                             24.10.00a345-cuda11_py312_240918_g0a71521c91_345 file:///tmp/tmp.QW5CaQYdHD
cudf_kafka:                       24.10.00a345-cuda11_py312_240918_g0a71521c91_345 file:///tmp/tmp.QW5CaQYdHD
cugraph:                          24.10.00a78-cuda11_py312_240919_g8b1a43727_78    rapidsai-nightly
cuml:                             24.10.00a58-cuda11_py312_240919_g7de88314d_58    rapidsai-nightly
cuproj:                           24.10.00a64-cuda11_py312_240919_gc4aacfb2_64     file:///tmp/tmp.F6KrsdMIIX
cupy:                             13.3.0-py312h8e83189_0                           conda-forge
cupy-core:                        13.3.0-py312h53955ab_0                           conda-forge
cuspatial:                        24.10.00a64-cuda11_py312_240919_gc4aacfb2_64     file:///tmp/tmp.F6KrsdMIIX
custreamz:                        24.10.00a345-cuda11_py312_240918_g0a71521c91_345 file:///tmp/tmp.QW5CaQYdHD
cuvs:                             24.10.00a65-cuda11_py312_240919_gbfc611a_65      rapidsai-nightly
cuxfilter:                        24.10.00a22-cuda11_py312_240919_gcd699b8_22      rapidsai-nightly
...
dask-core:                        2024.8.3a240912-py_g89189546a_14                 dask/label/dev
dask-cuda:                        24.10.00a22-py312_240919_g637c504_22             rapidsai-nightly
dask-cudf:                        24.10.00a345-cuda11_py312_240918_g0a71521c91_345 file:///tmp/tmp.QW5CaQYdHD
...
distributed-ucxx:                 0.40.00a-py3.12_240919_gb9e065c_42               file:///tmp/tmp.gywDNsq2Pm
...
fmt:                              11.0.2-h434a139_0                                conda-forge
...
libcudf:                          24.10.00a345-cuda11_240918_g0a71521c91_345       file:///tmp/tmp.UL9ngQzWMw
libcudf_kafka:                    24.10.00a345-cuda11_240918_g0a71521c91_345       file:///tmp/tmp.UL9ngQzWMw
...
libcugraph:                       24.10.00a78-cuda11_240919_g8b1a43727_78          rapidsai-nightly
libcugraph_etl:                   24.10.00a78-cuda11_240919_g8b1a43727_78          rapidsai-nightly
libcugraphops:                    24.10.00a13-cuda11_240919_g19c39118_13           rapidsai-nightly
libcuml:                          24.10.00a58-cuda11_240919_g7de88314d_58          rapidsai-nightly
libcumlprims:                     24.10.00a-cuda11_240919_gddfb9dd_8               rapidsai-nightly
...
libcuspatial:                     24.10.00a64-cuda11_240919_gc4aacfb2_64           file:///tmp/tmp.wgUzrOsFLv
libcuvs:                          24.10.00a65-cuda11_240919_gbfc611a_65            rapidsai-nightly
...
libkvikio:                        24.10.00a-cuda11_240919_ge926fad_45              rapidsai-nightly
...
libraft:                          24.10.00a55-cuda11_240919_g67334b78_55           file:///tmp/tmp.Qwh82vrpC0
libraft-headers:                  24.10.00a55-cuda11_240919_g67334b78_55           file:///tmp/tmp.Qwh82vrpC0
libraft-headers-only:             24.10.00a55-cuda11_240919_g67334b78_55           file:///tmp/tmp.Qwh82vrpC0
...
librmm:                           24.10.00a59-cuda11_240919_ga175083c_59           file:///tmp/tmp.Sx3mybL6rc
...
libucxx:                          0.40.00a-cuda11_240919_gb9e065c_42               file:///tmp/tmp.gywDNsq2Pm
...
nx-cugraph:                       24.10.00a78-py312_240919_g8b1a43727_78           rapidsai-nightly
...
pandas:                           2.2.2-py312h1d6d2e6_1                            conda-forge
...
pylibcudf:                        24.10.00a345-cuda11_py312_240918_g0a71521c91_345 file:///tmp/tmp.QW5CaQYdHD
pylibcugraph:                     24.10.00a78-cuda11_py312_240919_g8b1a43727_78    rapidsai-nightly
pylibraft:                        24.10.00a55-cuda11_py312_240919_g67334b78_55     file:///tmp/tmp.tQTBYcg8IB
...
python:                           3.12.5-h2ad013b_0_cpython                        conda-forge
...
raft-dask:                        24.10.00a55-cuda11_py312_240919_g67334b78_55     file:///tmp/tmp.tQTBYcg8IB
rapids:                           24.10.00a-cuda11_py312_240919_ged5da95_11        file:///tmp/conda-bld-output
rapids-dask-dependency:           24.10.00a5-py_0                                  rapidsai-nightly
rapids-xgboost:                   24.10.00a-cuda11_py312_240919_ged5da95_11        file:///tmp/conda-bld-output
...
rmm:                              24.10.00a59-cuda11_py312_240919_ga175083c_59     file:///tmp/tmp.5Q48Rl6pQC
...
spdlog:                           1.14.1-hed91bc2_1                                conda-forge
...
ucx:                              1.17.0-h0104b51_3                                conda-forge
...
ucx-py:                           0.40.00a14-py312_240919_g45a11ec_14              rapidsai-nightly
ucxx:                             0.40.00a-cuda11_py3.12_240919_gb9e065c_42        file:///tmp/tmp.gywDNsq2Pm
...

(build link)

@jameslamb jameslamb added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Sep 19, 2024
@jameslamb jameslamb changed the title WIP: remove pins on geospatial libraries, RAPIDS nightlies [DO NOT MERGE] remove pins on geospatial libraries, RAPIDS nightlies Sep 19, 2024
@jameslamb jameslamb changed the title [DO NOT MERGE] remove pins on geospatial libraries, RAPIDS nightlies remove pins on geospatial libraries, RAPIDS nightlies Sep 19, 2024
@jameslamb jameslamb marked this pull request as ready for review September 19, 2024 16:56
@jameslamb jameslamb requested review from a team as code owners September 19, 2024 16:56
@jameslamb jameslamb requested review from AyodeAwe and bdice and removed request for AyodeAwe September 19, 2024 16:56
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart move! I wouldn't have thought to test this repository in CI as a part of the fmt/spdlog migration.

@jameslamb
Copy link
Member Author

I just added cuml and cumlprims_mg PR artifacts here, to get a stronger test.... still see the expected versions of fmt and spdlog being pulled in 🎉

https://github.com/rapidsai/integration/actions/runs/11000951222/job/30544508462?pr=722#step:7:1138

@jameslamb jameslamb removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Sep 23, 2024
@jameslamb
Copy link
Member Author

🎉 rapids is building successfully, with the newer versions of fmt and spdlog

fmt:                              11.0.2-h70be974_0                                conda-forge                 
...
spdlog:                           1.14.1-h9d9cc24_1                                conda-forge                 

(build link)

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit b794951 into rapidsai:branch-24.10 Sep 24, 2024
28 checks passed
@jameslamb jameslamb deleted the fmt-and-spdlog branch September 24, 2024 13:44
@jameslamb jameslamb mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants