Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in spilling documentation #1384

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented Sep 16, 2024

Small follow-up to #1383

  • Fixes a typo in a link that references the "Spilling from device" page
  • Small tweaks to the spilling discussion on the "best practices" page

@rjzamora rjzamora added 2 - In Progress Currently a work in progress doc Documentation non-breaking Non-breaking change labels Sep 16, 2024
@rjzamora rjzamora self-assigned this Sep 16, 2024
<https://docs.rapids.ai/api/cudf/stable/developer_guide/library_design/#spilling-to-host-memory>`.
<https://docs.rapids.ai/api/cudf/stable/developer_guide/library_design/#spilling-to-host-memory>`_.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only "required" change in this PR.

@rjzamora rjzamora added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Sep 16, 2024
@rjzamora rjzamora marked this pull request as ready for review September 16, 2024 17:20
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rjzamora .

@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Sep 16, 2024
@rjzamora
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit d5b70f0 into rapidsai:branch-24.10 Sep 16, 2024
27 checks passed
@rjzamora rjzamora deleted the fix-spilling-doc-bug branch September 17, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants