Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import AnyKeyFile, as per Distributed changes #1256

Conversation

pentschev
Copy link
Member

@pentschev pentschev commented Oct 4, 2023

dask/distributed#8195 has renamed CustomFile to AnyKeyFile, the import requires updating.

Additionally remove protocol.loads compatibility fix introduced in #1247 to include the fix from dask/distributed#8216 for the Dask-CUDA 23.10 which pinned to Distributed 2023.9.2. Starting from Distributed 2023.9.3, the fix is merged in Distributed and this isn't required anymore.

Closes #1246

dask/distributed#8195 has renamed `CustomFile`
to `AnyKeyFile`, the import requires updating.
@pentschev pentschev requested a review from a team as a code owner October 4, 2023 16:29
@pentschev pentschev marked this pull request as draft October 4, 2023 16:29
@github-actions github-actions bot added the python python code needed label Oct 4, 2023
@pentschev pentschev added bug Something isn't working 0 - Blocked Cannot progress due to external reasons non-breaking Non-breaking change labels Oct 4, 2023
@pentschev
Copy link
Member Author

This will be required when Dask/Distributed are unpinned.

@galipremsagar FYI

This change was introduced in
rapidsai#1247 to include the fix from
dask/distributed#8216 for the Dask-CUDA 23.10
which pinned to Distributed 2023.9.2. Starting from Distributed
2023.9.3, the fix is merged in Distributed and this isn't required
anymore.
@pentschev
Copy link
Member Author

Closing in favor of #1264.

@pentschev pentschev closed this Oct 24, 2023
@pentschev pentschev deleted the update-distributed-breaking-changes branch October 26, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Blocked Cannot progress due to external reasons bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UCX serialization errors after dumps_task removal from Distributed
2 participants