Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add telemetry #6126

Merged
merged 4 commits into from
Nov 15, 2024
Merged

add telemetry #6126

merged 4 commits into from
Nov 15, 2024

Conversation

msarahan
Copy link
Contributor

@msarahan msarahan commented Oct 29, 2024 •
edited
Loading

Enables telemetry during cuml's build process. This is currently done by parsing Github Actions run log metadata, and should have no impact on build/test times

Implement OpenTelemetry, as described in https://github.com/rapidsai/build-infra/issues/139

@msarahan msarahan added 2 - In Progress Currenty a work in progress Build or Dep Issues related to building the code or dependencies 5 - DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change ci Needs build-infra Requires input from the build infrastructure team labels Oct 29, 2024
@github-actions github-actions bot removed the ci label Oct 29, 2024
@msarahan msarahan added ci improvement Improvement / enhancement to an existing function and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Nov 4, 2024
@github-actions github-actions bot removed the ci label Nov 13, 2024
@msarahan msarahan marked this pull request as ready for review November 14, 2024 00:27
@msarahan msarahan requested a review from a team as a code owner November 14, 2024 00:27
@msarahan msarahan changed the title add telemetry (testing) add telemetry Nov 15, 2024
@msarahan msarahan added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Nov 15, 2024
@msarahan
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0f32e99 into rapidsai:branch-24.12 Nov 15, 2024
65 checks passed
@msarahan msarahan deleted the add-telemetry branch November 15, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@KyleFromNVIDIA KyleFromNVIDIA Awaiting requested review from KyleFromNVIDIA KyleFromNVIDIA is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team Build or Dep Issues related to building the code or dependencies improvement Improvement / enhancement to an existing function Needs build-infra Requires input from the build infrastructure team non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msarahan @bdice