Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to native traceback in cuml #6078

Open
wants to merge 9 commits into
base: branch-24.12
Choose a base branch
from

Conversation

galipremsagar
Copy link
Contributor

In cudf we have observed a ~10% speed up of pytest suite execution by switching pytest traceback to --native:

currently:

102474 passed, 2117 skipped, 902 xfailed in 892.16s (0:14:52)

--tb=short:

102474 passed, 2117 skipped, 902 xfailed in 898.99s (0:14:58)

--tb=no:

102474 passed, 2117 skipped, 902 xfailed in 815.98s (0:13:35)

--tb=native:

102474 passed, 2117 skipped, 902 xfailed in 820.92s (0:13:40)

This PR makes similar change to cuml.

xref: rapidsai/cudf#16851

@galipremsagar galipremsagar requested a review from a team as a code owner September 23, 2024 20:35
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Sep 23, 2024
@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 23, 2024
@dantegd
Copy link
Member

dantegd commented Sep 23, 2024

@galipremsagar those times are for the cuDF pytest suite? It might be worth to check the time savings for cuML, I got a fresh container so can check those times in the next couple of days if so

@galipremsagar
Copy link
Contributor Author

@dantegd Yes, the timing improvements I posted above are of cudf pytest suite. cuml seems to have even better speedups, almost ~20% faster:

This PR:

==== 466 skipped, 9 xfailed, 201 xpassed, 25 warnings in 1432.43s (0:23:52) ====

link: https://github.com/rapidsai/cuml/actions/runs/11002114744/job/30550052027?pr=6078#step:7:1802

Other most recently merged PR:

==== 466 skipped, 9 xfailed, 201 xpassed, 3 warnings in 1696.39s (0:28:16) =====

link: https://github.com/rapidsai/cuml/actions/runs/10999896809/job/30543198516#step:7:1622

@trivialfis
Copy link
Member

Super nice! I should try this for XGBoost as well.

@dantegd dantegd changed the base branch from branch-24.10 to branch-24.12 October 6, 2024 18:59
@dantegd
Copy link
Member

dantegd commented Oct 17, 2024

/merge

@divyegala
Copy link
Member

@galipremsagar could you please check what's going wrong with the pytests in this PR? I can't quite figure out what the error is exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants