-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to native traceback in cuml
#6078
base: branch-24.12
Are you sure you want to change the base?
Conversation
@galipremsagar those times are for the cuDF pytest suite? It might be worth to check the time savings for cuML, I got a fresh container so can check those times in the next couple of days if so |
@dantegd Yes, the timing improvements I posted above are of This PR: ==== 466 skipped, 9 xfailed, 201 xpassed, 25 warnings in 1432.43s (0:23:52) ==== link: https://github.com/rapidsai/cuml/actions/runs/11002114744/job/30550052027?pr=6078#step:7:1802 Other most recently merged PR: ==== 466 skipped, 9 xfailed, 201 xpassed, 3 warnings in 1696.39s (0:28:16) ===== link: https://github.com/rapidsai/cuml/actions/runs/10999896809/job/30543198516#step:7:1622 |
Super nice! I should try this for XGBoost as well. |
/merge |
@galipremsagar could you please check what's going wrong with the pytests in this PR? I can't quite figure out what the error is exactly. |
In cudf we have observed a ~10% speed up of pytest suite execution by switching pytest traceback to
--native
:This PR makes similar change to
cuml
.xref: rapidsai/cudf#16851