Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs for simplicial_set #6042

Merged
merged 8 commits into from
Sep 24, 2024

Conversation

Intron7
Copy link
Contributor

@Intron7 Intron7 commented Aug 22, 2024

fixes #6036

Copy link

copy-pr-bot bot commented Aug 22, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dantegd
Copy link
Member

dantegd commented Aug 26, 2024

/ok to test

@dantegd dantegd added doc Documentation non-breaking Non-breaking change labels Aug 26, 2024
@viclafargue
Copy link
Contributor

Thanks for the PR @Intron7. Would it be possible to reverse the order of the two functions? I think that the fuzzy_simplicial_set function is supposed to be used in first (also alphabetical order).

@Intron7
Copy link
Contributor Author

Intron7 commented Aug 29, 2024

@viclafargue switched it

@divyegala
Copy link
Member

/ok to test

Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@divyegala
Copy link
Member

/ok to test

@divyegala
Copy link
Member

@Intron7 could you fix the style check errors in this PR?

@dantegd
Copy link
Member

dantegd commented Sep 24, 2024

/ok to test

@divyegala
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit f818527 into rapidsai:branch-24.10 Sep 24, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add simplicial_set_embedding & fuzzy_simplicial_set
4 participants