-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce memory_footprint for sparse PCA transform #5964
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ok to test |
lowener
added
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Jul 15, 2024
ok I added the right year in the cupyright |
/ok to test |
I think I can't fix the issue on the PR since it's in regards to the new layout |
Intron7
force-pushed
the
sparse_pca-update
branch
from
July 18, 2024 10:07
121945b
to
99b20f6
Compare
@lowener I merged in the updated main branch |
/ok to test |
/ok to test |
dantegd
changed the title
reduce memory_footprint for transform
reduce memory_footprint for sparse PCA transform
Jul 28, 2024
dantegd
approved these changes
Jul 28, 2024
/ok to test |
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
Cython / Python
Cython or Python issue
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sparse PCA still densified
X
during the transform step. This defeats the purpose of a sparse PCA in a sense. Howeveris the same as
The new implementation is faster (but mainly due to the fact that we don't have to rely on cupy's
to_array()
) and uses a lot less memory.