Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable dice metric for UMAP and Pairwise Distances #5943

Open
wants to merge 13 commits into
base: branch-24.08
Choose a base branch
from
Open

Enable dice metric for UMAP and Pairwise Distances #5943

wants to merge 13 commits into from

Conversation

aamijar
Copy link
Contributor

@aamijar aamijar commented Jun 18, 2024

Closes #5129

Related to rapidsai/raft#2359

  1. Enables dice metric for UMAP
  2. Enables dice metric for cuml.metrics.pairwise_distances

@aamijar aamijar requested review from a team as code owners June 18, 2024 23:48
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 18, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added Cython / Python Cython or Python issue CMake CUDA/C++ labels Jun 18, 2024
divyegala
divyegala approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, pre-approving

cpp/src/metrics/pairwise_distance_dice.cu Outdated Show resolved Hide resolved
cpp/src/metrics/pairwise_distance_dice.cu Outdated Show resolved Hide resolved
@divyegala divyegala added feature request New feature or request non-breaking Non-breaking change labels Jun 24, 2024
@divyegala
Copy link
Member

/ok to test

@divyegala
Copy link
Member

/ok to test

bdice
bdice approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving CMake changes but I have comments on other parts of the code.

(I had to review this one, given my name 😉)

cpp/src/metrics/pairwise_distance_dice.cu Outdated Show resolved Hide resolved
cpp/src/metrics/pairwise_distance_dice.cu Outdated Show resolved Hide resolved
cpp/src/metrics/pairwise_distance_dice.cuh Outdated Show resolved Hide resolved
python/cuml/manifold/umap_utils.pyx Outdated Show resolved Hide resolved
python/cuml/manifold/umap_utils.pyx Outdated Show resolved Hide resolved
python/cuml/manifold/umap_utils.pyx Outdated Show resolved Hide resolved
python/cuml/metrics/pairwise_distances.pyx Outdated Show resolved Hide resolved
python/cuml/metrics/pairwise_distances.pyx Outdated Show resolved Hide resolved
python/cuml/metrics/pairwise_distances.pyx Outdated Show resolved Hide resolved
@divyegala
Copy link
Member

/ok to test

@divyegala
Copy link
Member

/ok to test

@msarahan msarahan mentioned this pull request Jun 26, 2024
Merged
@divyegala
Copy link
Member

/ok to test

@dantegd
Copy link
Member

dantegd commented Jun 28, 2024

/ok to test

@lowener
Copy link
Contributor

lowener commented Jul 9, 2024

/ok to test

@lowener
Copy link
Contributor

lowener commented Jul 11, 2024

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
CMake CUDA/C++ Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Support for Dice coefficient as a metric in UMAP
5 participants
@aamijar @divyegala @dantegd @lowener @bdice