Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dockerfile. #5534

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Remove Dockerfile. #5534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bef0bd
Remove Dockerfile.
bdice Jul 31, 2023
c731b41
Merge branch 'branch-23.08' into remove-dockerfile
bdice Jul 31, 2023
2346dd8
Merge branch 'branch-23.08' into remove-dockerfile
bdice Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,4 @@ build.sh @rapidsai/cuml-cmake-codeowners
.github/ @rapidsai/ops-codeowners
ci/ @rapidsai/ops-codeowners
conda/ @rapidsai/ops-codeowners
**/Dockerfile @rapidsai/ops-codeowners
**/.dockerignore @rapidsai/ops-codeowners
dependencies.yaml @rapidsai/ops-codeowners
dependencies.yaml @rapidsai/ops-codeowners
26 changes: 0 additions & 26 deletions Dockerfile
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,9 @@ repo](https://github.com/rapidsai/notebooks-contrib).

## Installation

See [the RAPIDS Release
Selector](https://rapids.ai/start.html#rapids-release-selector) for the command
line to install either nightly or official release cuML packages via Conda or
Docker.
See [the RAPIDS Release Selector](https://docs.rapids.ai/install#selector) for
the command line to install either nightly or official release cuML packages
via Conda or Docker.

## Build/Install from Source
See the build [guide](BUILD.md).
Expand Down
29 changes: 3 additions & 26 deletions docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,34 +4,11 @@
#### [Build and install cuML](../BUILD.md)

#### Generate the docs
```shell script
```bash
bash build.sh cppdocs pydocs
```

#### Once the process finishes, documentation can be found in build/html
```shell script
xdg-open build/html/api.html`
```

## Building via Docker
Pull or create the cuML [docker container](https://hub.docker.com/r/rapidsai/rapidsai/).

### Start cuML container:
```
docker run -p 8000:8000 -it cuml bash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is referencing the container that we're removing in this PR. It seems like this method of building docs is not viable anymore, so I removed it.

```

### Setup container's conda env for building docs:
```
sudo sh setup.sh ${cuML-container-id}
```

### Build & host docs from container:
```
sudo sh build.sh ${cuML-container-id}
```

### Copy docs from container to host:
```
docker cp ${cuML-container-id}:/docs/build/html .
```bash
xdg-open build/html/api.html
```