fix libcudf pins cu11 #18161
Open
fix libcudf pins cu11 #18161
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bradley Dice <[email protected]>
gforsyth
added
improvement
github-actions
bot
added
libcudf
gforsyth
force-pushed
the
fix_libcudf_pins_cu11
branch
from
d81f3b0 to
2771d4b
Compare
bdice
reviewed
Mar 4, 2025
conda/recipes/libcudf/recipe.yaml
Outdated
| @@ -138,6 +138,7 @@ outputs: | |||
| - cuda-nvrtc | |||
| - cuda-nvtx | |||
| - cuda-version | |||
| - cudatoolkit | |||
There was a problem hiding this comment.
Should this be conditional?
Suggested change
| - cudatoolkit | |
| - if: cuda_major == "11" | |
| then: | |
| - cudatoolkit |
There was a problem hiding this comment.
Similarly, perhaps we should ignore exports from cuda-cudart, cuda-nvrtc, cuda-nvtx, libcurand for cuda_major != "11".
There was a problem hiding this comment.
Probably, I'm going to check the logs of a previous run and check on which overpinned dependencies might cause trouble
There was a problem hiding this comment.
ignoring things that aren't in scope doesn't cause problems, so I can circle back to cuda-nvrtc and friends when I have some followup fixes, but this should get things working
There was a problem hiding this comment.
but the cudatoolkit ignore is now conditional
github-actions
bot
removed
libcudf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix overconstrained libcudf conda package for cuda 11
Description
cudatoolkitinherited from thecompilers('cuda')metapackage is imposing anWe ignore that run export and rely on the the pin compatible
cuda-versionChecklist