Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine separate ConfigureNVBench calls to fix cpp conda builds #18155

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

gforsyth
Copy link
Contributor

@gforsyth gforsyth commented Mar 4, 2025

Description

Two PRs merged in quick succession each added a separate transform benchmark with the same name, leading CMake to get angry:

5b0a85b
8ca4bc4

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@gforsyth gforsyth requested a review from a team as a code owner March 4, 2025 14:47
@gforsyth gforsyth added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 4, 2025
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Mar 4, 2025
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! We try to keep the CMake file lists alphabetized.

@gforsyth
Copy link
Contributor Author

gforsyth commented Mar 4, 2025

Thanks for this fix! We try to keep the CMake file lists alphabetized.

Question about general project guidelines -- is that alphabetization something blocking this? Do we want to re-run CI for that cosmetic change or try to fix it in a follow-up alongside other packaging changes?

@lamarrr
Copy link
Contributor

lamarrr commented Mar 4, 2025

Thanks for the fix!

@davidwendt
Copy link
Contributor

Thanks for this fix! We try to keep the CMake file lists alphabetized.

Question about general project guidelines -- is that alphabetization something blocking this? Do we want to re-run CI for that cosmetic change or try to fix it in a follow-up alongside other packaging changes?

CI is barely half way through so if you could push a fix now then the current run will automatically be cancelled.
Otherwise, it is probably not worth holding up a merge.

@bdice
Copy link
Contributor

bdice commented Mar 4, 2025

I agree with David here. I left that as an optional fix / for future awareness. I did consider applying the commit myself, to avoid a time-delay that might leave us in a hard decision (this passed, should we merge or apply the fix?). I probably should've applied it immediately.

I think you made the right call, and we can add a /merge so this goes in quickly to unblock other builds.

@bdice
Copy link
Contributor

bdice commented Mar 4, 2025

/merge

@rapids-bot rapids-bot bot merged commit 29b81eb into rapidsai:branch-25.04 Mar 4, 2025
108 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants