-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine separate ConfigureNVBench calls to fix cpp conda builds #18155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix! We try to keep the CMake file lists alphabetized.
Question about general project guidelines -- is that alphabetization something blocking this? Do we want to re-run CI for that cosmetic change or try to fix it in a follow-up alongside other packaging changes? |
Thanks for the fix! |
CI is barely half way through so if you could push a fix now then the current run will automatically be cancelled. |
Co-authored-by: Bradley Dice <[email protected]>
I agree with David here. I left that as an optional fix / for future awareness. I did consider applying the commit myself, to avoid a time-delay that might leave us in a hard decision (this passed, should we merge or apply the fix?). I probably should've applied it immediately. I think you made the right call, and we can add a |
/merge |
29b81eb
into
rapidsai:branch-25.04
Description
Two PRs merged in quick succession each added a separate transform benchmark with the same name, leading CMake to get angry:
5b0a85b
8ca4bc4
Checklist