Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calls to KvikIO's config setter #18144

Merged

Conversation

kingcrimsontianyu
Copy link
Contributor

Description

KvikIO has changed the function names of the config setters to improve clarity (rapidsai/kvikio#644). This PR updates the setter calls in cuDF accordingly.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Mar 3, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 3, 2025
@kingcrimsontianyu kingcrimsontianyu added bug Something isn't working non-breaking Non-breaking change libcudf Affects libcudf (C++/CUDA) code. and removed libcudf Affects libcudf (C++/CUDA) code. labels Mar 3, 2025
@kingcrimsontianyu kingcrimsontianyu marked this pull request as ready for review March 3, 2025 16:07
@kingcrimsontianyu kingcrimsontianyu requested a review from a team as a code owner March 3, 2025 16:07
@kingcrimsontianyu kingcrimsontianyu marked this pull request as draft March 3, 2025 16:07
@kingcrimsontianyu
Copy link
Contributor Author

Sending back to draft: Waiting a little while for KvikIO's update to be visible.

@kingcrimsontianyu kingcrimsontianyu marked this pull request as ready for review March 3, 2025 16:40
@bdice
Copy link
Contributor

bdice commented Mar 3, 2025

We will need an admin-merge on this to unblock #18136, which is also blocking CI.

@AyodeAwe AyodeAwe merged commit 0cf6698 into rapidsai:branch-25.04 Mar 3, 2025
83 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants