Add pylibcudf.gpumemoryview support for len()/nbytes
#18133
Merged
+80
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
pentschev
added
feature request
Matt711
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Thanks @pentschev, can you update the type stub? https://github.com/rapidsai/cudf/blob/branch-25.04/python/pylibcudf/pylibcudf/gpumemoryview.pyi
rjzamora
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
I definitely prefer this over rapidsai/rapids-dask-dependency#89
|
Agreed, closed that in favor of the change in this PR. |
pentschev
added
3 - Ready for Review
3 tasks
raydouglass
pushed a commit
that referenced
this pull request
Mar 3, 2025
This test is failing in multiple places right now, such as [this run](https://github.com/rapidsai/cudf/actions/runs/13595690128/job/38014725800) on #18133 and [this run](https://github.com/rapidsai/cudf/actions/runs/13636334843/job/38118996773?pr=18136) on #18136. Let's skip it until we can debug why so that we unblock other CI. --------- Co-authored-by: Peter Andreas Entschev <[email protected]>
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
len()andnbytesinpylibcudf.gpumemoryview. Having those methods is helpful to ensure proper serialization in Dask/Distributed, as utility methods that serialize objects, in this case used by cudf-polars, may use the appropriate method or property to determine the size of the object being transferred.Checklist