Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify DecimalDtype and DecimalColumn operations #18111

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

mroeschke
Copy link
Contributor

Description

Broken off (the non-breaking parts) from #18035 as that PR will probably not move forward since it would require a pyarrow minimum version bump to 19

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 26, 2025
@mroeschke mroeschke self-assigned this Feb 26, 2025
@mroeschke mroeschke requested a review from a team as a code owner February 26, 2025 20:49
):
# TODO: Should it be possible to cast scalars of other numerical
# types to decimal?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ultimately the same question as #7680 CC @brandon-b-miller

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 7713bc1 into rapidsai:branch-25.04 Feb 27, 2025
105 of 106 checks passed
@mroeschke mroeschke deleted the ref/decimaldtype branch February 27, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants