Fix scatter_by_map with spilling enabled #18095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
bug
Matt711
approved these changes
Feb 25, 2025
Comment on lines
+3311
to
+3314
| @acquire_spill_lock() | ||
| def split_from_pylibcudf(split: list[plc.Column]) -> list[ColumnBase]: | ||
| return [ColumnBase.from_pylibcudf(col) for col in split] | ||
|
|
There was a problem hiding this comment.
Does this work?
Suggested change
| @acquire_spill_lock() | |
| def split_from_pylibcudf(split: list[plc.Column]) -> list[ColumnBase]: | |
| return [ColumnBase.from_pylibcudf(col) for col in split] | |
| with acquire_spill_lock() | |
| columns = [ColumnBase.from_pylibcudf(col) for col in split] |
There was a problem hiding this comment.
split here is an iterator variable (from for split in columns_split) below.
So in order to do it like this I would have to do
with acquire_spill_lock():
column = [[ColumnBase.from_pylibcudf(col) for col in split] for split in columns_split]I could put the entire operation in the with acquire_spill_lock() block, but I would prefer tightly scope the operation that definitely needs the spill lock.
There was a problem hiding this comment.
Oh thanks I didn't see the for split in. Sounds good
| return [ | ||
| self._from_columns_like_self( | ||
| [ColumnBase.from_pylibcudf(col) for col in split], | ||
| split_from_pylibcudf(split), |
There was a problem hiding this comment.
Suggested change
| split_from_pylibcudf(split), | |
| columns, |
|
/merge |
rapids-bot
bot
merged commit d8b3d80
into
rapidsai:branch-25.04
109 of 110 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #18088
Before the old Cython bindings of
columns_splitspill locked the conversion from libcudf to a cudf Python column. When I replaced these bindings, this spill locking was removed during the refactor.I'm spot checking that other APIs are not affected. If so I can open PRs for those
Checklist