Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump polars version to <1.24 #18076

Merged

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Feb 24, 2025

Description

The PR upgrades the Polars version to 1.23.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Feb 24, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change labels Feb 24, 2025
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars and removed feature request New feature or request non-breaking Non-breaking change labels Feb 24, 2025
@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change labels Feb 24, 2025
@Matt711
Copy link
Contributor Author

Matt711 commented Feb 24, 2025

/ok to test

@Matt711 Matt711 marked this pull request as ready for review February 24, 2025 15:32
@Matt711 Matt711 requested review from a team as code owners February 24, 2025 15:32
@Matt711 Matt711 requested review from bdice and wence- February 24, 2025 15:32
@@ -197,7 +197,6 @@ def pytest_configure(config: pytest.Config) -> None:
"tests/unit/io/test_multiscan.py::test_include_file_paths[scan_csv-write_csv]": "Need to expose include_file_paths xref: cudf#18012",
"tests/unit/streaming/test_streaming_io.py::test_parquet_eq_statistics[False]": "Debug output on stderr doesn't match",
# Maybe flaky, order-dependent?
"tests/unit/test_projections.py::test_schema_full_outer_join_projection_pd_13287": "Order-specific result check, query is correct but in different order",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Polars doesn't check the row order, so this passes. This is not dependent on #17698.

@Matt711 Matt711 marked this pull request as draft February 25, 2025 19:22
Copy link

copy-pr-bot bot commented Feb 25, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Matt711
Copy link
Contributor Author

Matt711 commented Feb 25, 2025

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Feb 25, 2025

Tests are failing because polars-cloud (a dependency of polars) currently only supports 1.22. So polars==1.22 is being installed in the CI job instead of polars 1.23

@Matt711
Copy link
Contributor Author

Matt711 commented Feb 25, 2025

/ok to test

@Matt711 Matt711 marked this pull request as ready for review February 26, 2025 01:43
@Matt711 Matt711 requested a review from a team as a code owner February 26, 2025 01:43
@Matt711
Copy link
Contributor Author

Matt711 commented Feb 27, 2025

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Feb 27, 2025

/ok to test

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing one typo then approving.

@bdice
Copy link
Contributor

bdice commented Feb 27, 2025

/ok to test

@Matt711
Copy link
Contributor Author

Matt711 commented Feb 27, 2025

/merge

@rapids-bot rapids-bot bot merged commit b8ec71a into rapidsai:branch-25.04 Feb 27, 2025
107 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf.polars Issues specific to cudf.polars feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants