-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send sccache logs to telemetry #18069
base: branch-25.04
Are you sure you want to change the base?
Conversation
7131f1e
to
2822aea
Compare
I don't see the ninja logs being sent. Perhaps just a typo in the title? I got my hopes up there for a minute. |
Sorry @davidwendt for the false hopes. The approach here will extend to ninja logs very easily. I don't know how to parse ninja logs into something useful, though. Brad pointed me to https://github.com/rapidsai/cudf/blob/branch-25.04/cpp/scripts/sort_ninja_log.py, but I haven't had a chance to port that to the telemetry side. Am I reading it correctly that you want a mapping of some number of filenames to their compile times? Is it OK to have the list truncated to some small-ish number of files (10?) Cardinality explosion is my main concern with having this in the telemetry results. |
Yes. If we could get at least the top 25 perhaps? I'm hoping the telemetry data can provide a history to see if compile-times change over time perhaps? I can help you with the |
15caf42
to
92a23d3
Compare
I linked this PR for its comments at https://github.com/rapidsai/build-infra/issues/142 I need to finish out the existing functionality, but I hope to return to adding this soon. |
Utiilizes work from rapidsai/shared-workflows#281 and rapidsai/shared-actions#44 to capture more build statistics into the telemetry data.
Example of captured sccache data from RMM:
This data will of course be plot-able over time, which should be useful.