Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send sccache logs to telemetry #18069

Open
wants to merge 4 commits into
base: branch-25.04
Choose a base branch
from

Conversation

msarahan
Copy link
Contributor

Utiilizes work from rapidsai/shared-workflows#281 and rapidsai/shared-actions#44 to capture more build statistics into the telemetry data.

Example of captured sccache data from RMM:

Screenshot 2025-02-21 at 10 40 37 AM

This data will of course be plot-able over time, which should be useful.

@msarahan msarahan requested a review from a team as a code owner February 21, 2025 21:09
@msarahan msarahan requested a review from raydouglass February 21, 2025 21:09
@msarahan msarahan added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 21, 2025
@msarahan msarahan force-pushed the add-telemetry-cache-logs branch from 7131f1e to 2822aea Compare February 26, 2025 14:49
@msarahan msarahan requested a review from a team as a code owner February 26, 2025 14:49
@msarahan
Copy link
Contributor Author

Sccache data is present on the output of this PR:
cudf_hit_rate

CC @bdice @vyasr

@msarahan msarahan closed this Feb 27, 2025
@msarahan msarahan reopened this Feb 27, 2025
@davidwendt
Copy link
Contributor

I don't see the ninja logs being sent. Perhaps just a typo in the title? I got my hopes up there for a minute.

@msarahan msarahan changed the title send sccache, ninja, and filesize logs to telemetry send sccache logs to telemetry Feb 28, 2025
@msarahan
Copy link
Contributor Author

Sorry @davidwendt for the false hopes. The approach here will extend to ninja logs very easily. I don't know how to parse ninja logs into something useful, though. Brad pointed me to https://github.com/rapidsai/cudf/blob/branch-25.04/cpp/scripts/sort_ninja_log.py, but I haven't had a chance to port that to the telemetry side. Am I reading it correctly that you want a mapping of some number of filenames to their compile times? Is it OK to have the list truncated to some small-ish number of files (10?) Cardinality explosion is my main concern with having this in the telemetry results.

@davidwendt
Copy link
Contributor

... Am I reading it correctly that you want a mapping of some number of filenames to their compile times? Is it OK to have the list truncated to some small-ish number of files (10?) Cardinality explosion is my main concern with having this in the telemetry results.

Yes. If we could get at least the top 25 perhaps? I'm hoping the telemetry data can provide a history to see if compile-times change over time perhaps? I can help you with the sort_ninja_log.py utility as well.

@msarahan msarahan force-pushed the add-telemetry-cache-logs branch from 15caf42 to 92a23d3 Compare March 4, 2025 00:30
@msarahan
Copy link
Contributor Author

msarahan commented Mar 4, 2025

I linked this PR for its comments at https://github.com/rapidsai/build-infra/issues/142

I need to finish out the existing functionality, but I hope to return to adding this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants