-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add seed parameter to cudf hash_character_ngrams #17994
base: branch-25.04
Are you sure you want to change the base?
Add seed parameter to cudf hash_character_ngrams #17994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment otherwise LGTM
/merge |
…to hash-char-ngrams-seed
I could use some help with the failures here. |
Looking at the logs. Its using the nightly version of cudf. I'm not sure why though. |
As posted offline, I suspect #17995 somehow changed the behavior of libcudf/pylibcudf/cudf not being installed from source |
Description
The seed parameter was added to
nvtext::hash_character_ngrams
in #17643 but was not added to the Python interface. This PR adds the parameter to the pylibcudf function and Python interface methods.Checklist