-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pickle and unpickling for all objects #17980
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/okay to test |
/okay to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So IIUC this works because when we fall back to pd.read_pickle under the hood pandas is going to call pickle methods on its own types, so we're intercepting them at the lower level of the copyreg module? That seems generally fine in the pickle.load
/pickle.dump
case, but does it make us reliant on the internals of pd.read_pickle
working in a certain way and calling the pickle
methods?
We should generally be fine because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation, that makes sense Prem. LGTM.
/merge |
c3d6b4c
into
rapidsai:branch-25.04
Description
Fixes: #15459
This PR fixes hangs in pickle and unpickling code by registering custom pickling and unpickling methods for all proxied types.
Checklist